Preview api lb profile #3020
Merged
Preview api lb profile #3020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-schndr
commented
Jul 11, 2023
tony-schndr
commented
Jul 11, 2023
tony-schndr
force-pushed
the
preview-api-lb-profile
branch
2 times, most recently
from
29af082
to
63d82b1
Compare
tony-schndr
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
facchettos,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
ellis-johnson,
yjst2012 and
anshulvermapatel
as code owners
tony-schndr
force-pushed
the
preview-api-lb-profile
branch
from
63d82b1
to
3f87b5f
Compare
tony-schndr
commented
Jul 13, 2023
SudoBrendan
previously approved these changes
Jul 25, 2023
bennerv
reviewed
Jul 26, 2023
| "x-ms-identifiers": [] | ||
| }, | ||
| "allocatedOutboundPorts": { | ||
| "description": "The desired number of allocated SNAT ports per VM. Allowed values are in the range of 0 to 64000 (inclusive). The default value is 1024.", |
There was a problem hiding this comment.
Load balancer gives SNAT ports in multiples of 8. If you provide a value not divisible by 8, the configuration operation is rejected. Each load balancing rule and inbound NAT rule consume a range of eight ports. If a load balancing or inbound NAT rule shares the same range of 8 as another, no extra ports are consumed.
Is 0 really a valid value?
There was a problem hiding this comment.
When setting allocatedOutboundPorts to 0 Azure will "dynamically" allocate ports, which is "Use the default number of ports" https://learn.microsoft.com/en-us/azure/load-balancer/load-balancer-outbound-connections#preallocatedports.
|
Please rebase pull request. |
SudoBrendan
added
next-up
next-release
tony-schndr
force-pushed
the
preview-api-lb-profile
branch
from
a1b608d
to
d2d81dc
Compare
SudoBrendan
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-3111
What this PR does / why we need it:
This PR adds the LoadBalancerProfile to the preview, admin, and internal API, static validation of the LoadBalancerProfile, and sets default loadBalancerProfile. I had intended to add Dynamic validation but that is probably going to add too much to this PR and makes more sense to add it during implementation of aro update.
The PreviewAPI includes all fields for this feature though only ManagedOutboundIPs is usable during phase 1 of this feature. This was done this way to not require multiple API releases.
Test plan for issue:
Added/updated existing unit tests. I also manually verified some API calls and validated the expected result in cosmos. This will be further tested once the aro update part is implemented.
Is there any documentation that needs to be updated for this PR?
Not yet